Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up .dockerignore file #3433

Closed

Conversation

agriyakhetarpal
Copy link
Member

Description

Related to #3312

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (774d56d) 99.58% compared to head (2ab9ca0) 99.58%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3433   +/-   ##
========================================
  Coverage    99.58%   99.58%           
========================================
  Files          256      256           
  Lines        19998    19998           
========================================
  Hits         19915    19915           
  Misses          83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @agriyakhetarpal, the file looks good but it might not control those unwanted files and folders inside the container as those are being generated while building the image, we would want to use commands to manage those files.
As far as I know .dockerignore is used to define the build context and that is already being handeled by .gitignore only as we are not copying the context but cloning from git here.

@agriyakhetarpal
Copy link
Member Author

Oh okay, I added this because I saw some of these files showing up in the Docker containers earlier, but I think they have been fixed in the latest image because they don't show up now. Cloning from the Git repository looks like a cleaner method, didn't notice that! Happy to close this if you think so

@arjxn-py
Copy link
Member

fixed in the latest image because they don't show up now.

If the issue has been fixed in latest image then yeah we can close it and if not we can try fixing it with adding some commands in Dockerfile.

@agriyakhetarpal
Copy link
Member Author

If the issue has been fixed in latest image then yeah we can close it and if not we can try fixing it with adding some commands in Dockerfile.

Just pulled and tested—closing, thanks, @arjxn-py!

@agriyakhetarpal agriyakhetarpal deleted the dockerignore branch October 10, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants