-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and update dependencies for Docker images #3317
Add and update dependencies for Docker images #3317
Conversation
Co-Authored-By: Arjun <[email protected]>
Co-Authored-By: Arjun <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3317 +/- ##
========================================
Coverage 99.58% 99.58%
========================================
Files 256 256
Lines 20117 20117
========================================
Hits 20034 20034
Misses 83 83 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Saransh Chopra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @agriyakhetarpal! A few comments below -
Co-Authored-By: Saransh Chopra <[email protected]>
Co-Authored-By: Saransh Chopra <[email protected]>
@Saransh-cpp and I both have ARM machines so debugging might be a bit difficult, @arjxn-py could you test the new changes locally? |
Hey, so sorry for the delay in response, I'll test this and confirm. |
No worries, I tested the images locally and fixed some errors with CMake. It requires a non-user installation if one installs it with |
This should be ready to merge but only after #3430 |
A gentle bump here, @arjxn-py and @Saransh-cpp! The Docker images here were working for me locally – now that we have multi-architecture images being pushed, I think it should be fine to go ahead with this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks nice, thanks @agriyakhetarpal.
I'll also confirm once after testing Dockerfile locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, sorry for the delay. Thanks, @agriyakhetarpal!
Description
See #3312
nox
is installed by default in both thebase
and thepybamm
environments[docs]
dependencies, addspandoc
, and and aTeXLive
distribution (for the latexify tests, rendering notebooks in the built documentation, et cetera).Note
This PR should be merged after #3316
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: