Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3051 - bpx activation energies #3242

Merged
merged 14 commits into from
Sep 19, 2023
Merged

Issue 3051 - bpx activation energies #3242

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
dfdfb32
add unique variable names for activation energies
darryl-ad Aug 7, 2023
a4dc8d5
Update CHANGELOG.md [#3051]
darryl-ad Aug 7, 2023
fa571cd
Update CHANGELOG.md
darryl-ad Aug 7, 2023
5f4daa0
fix Ea_k verbose name to match schema
darryl-ad Aug 7, 2023
ab95b28
fix formatting
darryl-ad Aug 7, 2023
9a5830a
refactor arrhenius definition
darryl-ad Aug 8, 2023
7defd7d
add arrhenius unit test
darryl-ad Aug 8, 2023
3edf2e3
add test for BPX constant functions
darryl-ad Aug 30, 2023
0d3be05
update changelog
darryl-ad Aug 31, 2023
2ea64d7
Merge branch 'develop' into issue3051-BPX-diffusivity-activation-ener…
darryl-ad Sep 4, 2023
c8e2d7b
Merge branch 'develop' into issue3051-BPX-diffusivity-activation-ener…
darryl-ad Sep 4, 2023
c943216
Merge branch 'develop' into issue3051-BPX-diffusivity-activation-ener…
darryl-ad Sep 8, 2023
dc3c6ed
Merge branch 'develop' into issue3051-BPX-diffusivity-activation-ener…
darryl-ad Sep 19, 2023
d130615
Update CHANGELOG.md
darryl-ad Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
- Implement the MSMR model ([#3116](https://github.com/pybamm-team/PyBaMM/pull/3116))

## Bug fixes

- Fixed bug causing incorrect activation energies using `create_from_bpx()` ([#3242](https://github.com/pybamm-team/PyBaMM/pull/3242))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this line down so the PRs are sorted in decreasing order? Happy to merge after that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

- Fixed a bug that caused incorrect results of “{Domain} electrode thickness change [m]” due to the absence of dimension for the variable `electrode_thickness_change`([#3329](https://github.com/pybamm-team/PyBaMM/pull/3329)).
- Fixed a bug that occured in `check_ys_are_not_too_large` when trying to reference `y-slice` where the referenced variable was not a `pybamm.StateVector` ([#3313](https://github.com/pybamm-team/PyBaMM/pull/3313)
- Fixed a bug with `_Heaviside._evaluate_for_shape` which meant some expressions involving heaviside function and subtractions did not work ([#3306](https://github.com/pybamm-team/PyBaMM/pull/3306))
- The `OneDimensionalX` thermal model has been updated to account for edge/tab cooling and account for the current collector volumetric heat capacity. It now gives the correct behaviour compared with a lumped model with the correct total heat transfer coefficient and surface area for cooling. ([#3042](https://github.com/pybamm-team/PyBaMM/pull/3042))
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.