-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Processed variables now get spatial variables automatically #3234
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3234 +/- ##
========================================
Coverage 99.71% 99.71%
========================================
Files 248 248
Lines 18826 18829 +3
========================================
+ Hits 18772 18775 +3
Misses 54 54
☔ View full report in Codecov by Sentry. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…-team/PyBaMM into issue-3200-2D-processed-variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one comment about the public/private API
pybamm/models/base_model.py
Outdated
|
||
@geometry.setter | ||
def geometry(self, geometry): | ||
self._geometry = geometry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should have a public setter class
Description
Processed variables now automatically take the names of the domains to plot automatically from spatial variables. This was to enable the plotting of 2D variables in arbitrary domains. Note that it required adding a
geometry
variable to the model as at the moment there is no way to get the geometry from a processed model, even though geometry is a key part of the model. Probably I didn't do it in the most efficient way so suggestions are welcome.Fixes #3200
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: