Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old url check #2759

Merged
merged 1 commit into from
Mar 10, 2023
Merged

remove old url check #2759

merged 1 commit into from
Mar 10, 2023

Conversation

valentinsulzer
Copy link
Member

@valentinsulzer valentinsulzer commented Mar 9, 2023

Description

No longer needed after #2734

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (998dc1a) 99.68% compared to head (6f9cf0e) 99.68%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2759   +/-   ##
========================================
  Coverage    99.68%   99.68%           
========================================
  Files          271      271           
  Lines        18991    18992    +1     
========================================
+ Hits         18932    18933    +1     
  Misses          59       59           

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tinosulzer!

@valentinsulzer valentinsulzer merged commit 1dc5266 into develop Mar 10, 2023
@valentinsulzer valentinsulzer deleted the remove_old_url_check branch March 10, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants