I2643 banded

[martinjrobins]

Description

provides an option for using a banded jacobian and sundials banded solvers for the idaklu solver

unfortunately, I'm not getting any speedup using the SPM or SPMe models, contrary to expectations...

Fixes #2643

see also #2217

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)

Key checklist:

• No style issues: $ pre-commit run
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

Base: 99.69% // Head: 99.69% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9cfd35b) compared to base (3c30f50).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2677   +/-   ##
========================================
  Coverage    99.69%   99.69%           
========================================
  Files          271      271           
  Lines        19586    19622   +36     
========================================
+ Hits         19526    19562   +36     
  Misses          60       60           

Impacted Files	Coverage Δ
pybamm/discretisations/discretisation.py	99.78% <ø> (ø)
pybamm/expression_tree/interpolant.py	100.00% <ø> (ø)
...bamm/expression_tree/operations/evaluate_python.py	99.29% <ø> (ø)
pybamm/input/parameters/ecm/example_set.py	100.00% <ø> (ø)
pybamm/meshes/one_dimensional_submeshes.py	100.00% <ø> (ø)
pybamm/meshes/scikit_fem_submeshes.py	100.00% <ø> (ø)
...full_battery_models/equivalent_circuit/thevenin.py	100.00% <ø> (ø)
...l_battery_models/lead_acid/base_lead_acid_model.py	100.00% <ø> (ø)
...ybamm/models/full_battery_models/lead_acid/full.py	100.00% <ø> (ø)
...ybamm/models/full_battery_models/lead_acid/loqs.py	100.00% <ø> (ø)
... and 86 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[rtimms]

thanks @martinjrobins looks good to me!