-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename to entrypoint to pybamm_parameter_sets
#2475
Conversation
Fix typo identified in pybamm-team#2452 Added emphasis on the need to install / reinstall the package
@tinosulzer Should be good to go |
Codecov ReportBase: 99.72% // Head: 99.72% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2475 +/- ##
===========================================
- Coverage 99.72% 99.72% -0.01%
===========================================
Files 258 257 -1
Lines 19264 18986 -278
===========================================
- Hits 19211 18933 -278
Misses 53 53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think parameter_sets
should be plural, and the entry points code edited to allow that
This reverts commit e47b1d6.
pybamm_parameter_sets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixed a typo in docs on adding a new parameter set and added emphasis on installing/reinstalling the parameter set package.
Typo found via: #2452