-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eliminate-julia #2453
eliminate-julia #2453
Conversation
0ab3abe
to
8bdc3e0
Compare
Codecov ReportBase: 99.72% // Head: 99.72% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2453 +/- ##
===========================================
- Coverage 99.72% 99.72% -0.01%
===========================================
Files 258 257 -1
Lines 19264 18986 -278
===========================================
- Hits 19211 18933 -278
Misses 53 53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, just need to update changelog saying all julia stuff is removed and pointing to where it is now
Description
Removes Julia code (moved to a different repo)
Fixes # (issue)
Makes pybamm easier to install on apple silicon.
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: