Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminate-julia #2453

Merged
merged 8 commits into from
Nov 14, 2022
Merged

eliminate-julia #2453

merged 8 commits into from
Nov 14, 2022

Conversation

aabills
Copy link
Contributor

@aabills aabills commented Nov 13, 2022

Description

Removes Julia code (moved to a different repo)

Fixes # (issue)
Makes pybamm easier to install on apple silicon.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@aabills aabills mentioned this pull request Nov 13, 2022
8 tasks
@aabills aabills closed this Nov 13, 2022
@aabills aabills reopened this Nov 13, 2022
@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Base: 99.72% // Head: 99.72% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (ebb2f6b) compared to base (8bdc3e0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2453      +/-   ##
===========================================
- Coverage    99.72%   99.72%   -0.01%     
===========================================
  Files          258      257       -1     
  Lines        19264    18986     -278     
===========================================
- Hits         19211    18933     -278     
  Misses          53       53              
Impacted Files Coverage Δ
pybamm/expression_tree/functions.py 100.00% <ø> (ø)
pybamm/models/base_model.py 98.48% <ø> (-0.05%) ⬇️
pybamm/util.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, just need to update changelog saying all julia stuff is removed and pointing to where it is now

@valentinsulzer valentinsulzer merged commit 5d9f320 into pybamm-team:develop Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants