Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More simplifications #2443

Merged
merged 13 commits into from
Nov 10, 2022
Merged

More simplifications #2443

merged 13 commits into from
Nov 10, 2022

Conversation

valentinsulzer
Copy link
Member

Description

Still more simplifications

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@valentinsulzer valentinsulzer marked this pull request as draft November 9, 2022 14:12
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 99.72% // Head: 99.72% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c2c0f28) compared to base (d5547da).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head c2c0f28 differs from pull request most recent head 37b96d0. Consider uploading reports for the commit 37b96d0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2443   +/-   ##
========================================
  Coverage    99.72%   99.72%           
========================================
  Files          258      258           
  Lines        19184    19211   +27     
========================================
+ Hits         19131    19158   +27     
  Misses          53       53           
Impacted Files Coverage Δ
pybamm/discretisations/discretisation.py 99.79% <100.00%> (-0.01%) ⬇️
pybamm/expression_tree/averages.py 100.00% <100.00%> (ø)
pybamm/expression_tree/binary_operators.py 100.00% <100.00%> (ø)
pybamm/expression_tree/broadcasts.py 100.00% <100.00%> (ø)
pybamm/expression_tree/concatenations.py 100.00% <100.00%> (ø)
pybamm/expression_tree/symbol.py 100.00% <100.00%> (ø)
pybamm/expression_tree/unary_operators.py 100.00% <100.00%> (ø)
pybamm/meshes/meshes.py 98.07% <100.00%> (+0.29%) ⬆️
...lectrolyte_diffusion/base_electrolyte_diffusion.py 100.00% <100.00%> (ø)
.../submodels/electrolyte_diffusion/full_diffusion.py 100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@valentinsulzer valentinsulzer marked this pull request as ready for review November 9, 2022 22:26
Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

CHANGELOG.md Outdated
@@ -6,6 +6,7 @@

## Optimizations

- Added more rules for simplifying expressions, especially around Concatenations. Also, meshes constructed from multiple domains are now memoized ([#2443](https://github.com/pybamm-team/PyBaMM/pull/2443))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Added more rules for simplifying expressions, especially around Concatenations. Also, meshes constructed from multiple domains are now memoized ([#2443](https://github.com/pybamm-team/PyBaMM/pull/2443))
- Added more rules for simplifying expressions, especially around Concatenations. Also, meshes constructed from multiple domains are now memorized ([#2443](https://github.com/pybamm-team/PyBaMM/pull/2443))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refers to memoization https://en.wikipedia.org/wiki/Memoization, but I will change it to "cached"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, didn't know that, sorry! If it is a word, happy to keep it as it is.

CHANGELOG.md Outdated Show resolved Hide resolved
@valentinsulzer valentinsulzer merged commit c0aa28d into develop Nov 10, 2022
@valentinsulzer valentinsulzer deleted the more-simplifications branch November 10, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants