-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add three dimensional interpolation #2380
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportBase: 99.66% // Head: 99.66% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2380 +/- ##
========================================
Coverage 99.66% 99.66%
========================================
Files 269 269
Lines 20145 20190 +45
========================================
+ Hits 20078 20123 +45
Misses 67 67
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just needs coverage
Currently updating to cover cases where nans and inconsistently shaped children are passed to the RGI (unfortunately it cannot handle these cases unlike interp2d and interp1d) |
Can you merge develop to see if that fixes benchmarks? |
Seems to fix it thanks! |
Description
Extended the interpolation class to allow 3D interpolants utiliizing scipys RegularGridInterpolator and allowed for conversion to casadi. I have added an minimal example script where the 3D interpolation is used in a model and solved. If you are happy with the coverage of the tests already then we can remove it or move to the integration tests.
Fixes #
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: