Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for initial soc in build #2375

Merged
merged 5 commits into from
Oct 18, 2022

Conversation

aabills
Copy link
Contributor

@aabills aabills commented Oct 17, 2022

  • add option in build to initialize soc
  • remove added dependency
  • add test

Description

move initial soc setting to its own function, which can be called from build
Fixes #2372

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 99.66% // Head: 99.66% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a859382) compared to base (7f06355).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2375   +/-   ##
========================================
  Coverage    99.66%   99.66%           
========================================
  Files          269      269           
  Lines        20201    20206    +5     
========================================
+ Hits         20134    20139    +5     
  Misses          67       67           
Impacted Files Coverage Δ
pybamm/simulation.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@valentinsulzer valentinsulzer merged commit c89445e into pybamm-team:develop Oct 18, 2022
@aabills aabills deleted the soc-to-build branch October 18, 2022 16:26
martinjrobins added a commit that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move initial soc out of solve
2 participants