-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2331 fix bug in size of yS numpy array when simulation stops early #2337
Conversation
Codecov ReportBase: 99.64% // Head: 99.64% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #2337 +/- ##
========================================
Coverage 99.64% 99.64%
========================================
Files 361 361
Lines 19918 19918
========================================
Hits 19847 19847
Misses 71 71
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test where an event is triggered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
CHANGELOG.md
Outdated
@@ -10,6 +10,7 @@ | |||
|
|||
## Bug fixes | |||
|
|||
- For simulations with events that cause the simulation to stop early, the sensitivities could be evaluated incorrectly to zero ([#2331](https://github.com/pybamm-team/PyBaMM/pull/2337)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be in "Unreleased" section
Description
fix bug in size of yS numpy array when simulation stops early
Fixes #2331
Type of change
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: