#1927 half-cell thermal models

[rtimms]

Description

Modifies thermal submodels so they work with half-cell models

Fixes #1927

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

Merging #1929 (aadec33) into develop (6f636bd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1929   +/-   ##
========================================
  Coverage    99.32%   99.32%           
========================================
  Files          346      346           
  Lines        18981    19002   +21     
========================================
+ Hits         18853    18874   +21     
  Misses         128      128           

Impacted Files	Coverage Δ
...dels/submodels/current_collector/potential_pair.py	100.00% <ø> (ø)
...m/models/full_battery_models/base_battery_model.py	99.76% <100.00%> (+<0.01%)	⬆️
...ollector/effective_resistance_current_collector.py	99.46% <100.00%> (+<0.01%)	⬆️
pybamm/models/submodels/thermal/base_thermal.py	100.00% <100.00%> (ø)
pybamm/models/submodels/thermal/isothermal.py	100.00% <100.00%> (ø)
pybamm/models/submodels/thermal/lumped.py	100.00% <100.00%> (ø)
...mal/pouch_cell/pouch_cell_1D_current_collectors.py	100.00% <100.00%> (ø)
...mal/pouch_cell/pouch_cell_2D_current_collectors.py	100.00% <100.00%> (ø)
pybamm/models/submodels/thermal/x_full.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8b44c3...aadec33. Read the comment docs.

[valentinsulzer]

There is still an anode in the half-cell, so it will contribute to the thermal problem in the same way as the current collectors do

[rtimms]

There is still an anode in the half-cell, so it will contribute to the thermal problem in the same way as the current collectors do

duh, sorry rushed into this. will fix it properly

[valentinsulzer]

No worries, would have done the same, only realized it as I was reviewing the PR. I guess "cell temperature" and "temperature that goes into the other equations (concentration/potential)" need to be separate variables

[rtimms]

No worries, would have done the same, only realized it as I was reviewing the PR. I guess "cell temperature" and "temperature that goes into the other equations (concentration/potential)" need to be separate variables

Yeah, you get away with it if you're happy with the interpretation that "Cell temperature" is either neg.elec./sep/pos.elec. or sep/work.elec. depending on if you are half-cell or not. But it means you can't use "x-full" with half-cells the way it is currently implemented.

[valentinsulzer]

Thanks! We can just figure out x-full later if someone needs it