Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solid tau now uses correct bruggeman coeff #1773

Merged
merged 7 commits into from
Dec 2, 2021
Merged

solid tau now uses correct bruggeman coeff #1773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2842f3e
solid tau now uses correct bruggeman coeff
dion-w Nov 1, 2021
76175f2
updated changelog for fixing issue #1734
dion-w Nov 1, 2021
ba430e6
Updated changelog with appropriate capital letters
dion-w Nov 2, 2021
27c1a67
Update changelog for issue #1734
dion-w Dec 1, 2021
0c3238e
Updated changelog with resolved issues
dion-w Dec 1, 2021
ec7afb7
Merge branch 'develop' into issue-1734-fix-solid-tortuosity
dion-w Dec 1, 2021
203c350
added bruggeman values for electrodes
dion-w Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# [Unreleased](https://github.com/pybamm-team/PyBaMM/) - 2021-12-01

## Bug fixes
- Solid tortuosity is now correctly calculated with Bruggeman coefficient of the respective electrode ([#1773](https://github.com/pybamm-team/PyBaMM/pull/1773))

# [v21.11](https://github.com/pybamm-team/PyBaMM/tree/v21.11) - 2021-11-30

## Features
Expand Down
2 changes: 2 additions & 0 deletions examples/notebooks/parameterization/parameterization.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1616,6 +1616,7 @@
" 'Negative electrode active material volume fraction': 0.75,\n",
" 'Negative particle radius [m]': 5.86e-06,\n",
" 'Negative electrode Bruggeman coefficient (electrolyte)': 1.5,\n",
" 'Negative electrode Bruggeman coefficient (electrode)': 1.5,\n",
" 'Negative electrode electrons in reaction': 1.0,\n",
" 'Negative electrode exchange-current density [A.m-2]': graphite_LGM50_electrolyte_exchange_current_density_Chen2020,\n",
" 'Negative electrode OCP entropic change [V.K-1]': 0.0,\n",
Expand All @@ -1626,6 +1627,7 @@
" 'Positive electrode active material volume fraction': 0.665,\n",
" 'Positive particle radius [m]': 5.22e-06,\n",
" 'Positive electrode Bruggeman coefficient (electrolyte)': 1.5,\n",
" 'Positive electrode Bruggeman coefficient (electrode)': 1.5,\n",
" 'Positive electrode electrons in reaction': 1.0,\n",
" 'Positive electrode exchange-current density [A.m-2]': nmc_LGM50_electrolyte_exchange_current_density_Chen2020,\n",
" 'Positive electrode OCP entropic change [V.K-1]': 0.0,\n",
Expand Down
4 changes: 2 additions & 2 deletions pybamm/models/submodels/tortuosity/bruggeman_tortuosity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ def get_coupled_variables(self, variables):
tor_n = None
else:
eps_n = variables["Negative electrode active material volume fraction"]
tor_n = eps_n ** param.b_e_n
tor_n = eps_n ** param.b_s_n

eps_p = variables["Positive electrode active material volume fraction"]
tor_s = pybamm.FullBroadcast(0, "separator", "current collector")
tor_p = eps_p ** param.b_e_p
tor_p = eps_p ** param.b_s_p

variables.update(
self._get_standard_tortuosity_variables(
Expand Down