Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove yang #1577

Merged
merged 5 commits into from
Aug 2, 2021
Merged

Remove yang #1577

merged 5 commits into from
Aug 2, 2021

Conversation

valentinsulzer
Copy link
Member

Description

Remove the Yang2017 model as the parameter set is incomplete and secret

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #1577 (7a99063) into develop (ef21abe) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1577      +/-   ##
===========================================
- Coverage    97.84%   97.83%   -0.01%     
===========================================
  Files          329      323       -6     
  Lines        17987    17915      -72     
===========================================
- Hits         17599    17527      -72     
  Misses         388      388              
Impacted Files Coverage Δ
pybamm/parameters/parameter_sets.py 100.00% <ø> (ø)
...models/full_battery_models/lithium_ion/Yang2017.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef21abe...7a99063. Read the comment docs.

@valentinsulzer
Copy link
Member Author

valentinsulzer commented Aug 1, 2021

For future ref if needed: commit 4a9d317 has most up-to-date Yang2017 parameters

@valentinsulzer valentinsulzer merged commit 358a9f9 into develop Aug 2, 2021
@valentinsulzer valentinsulzer deleted the remove-Yang branch August 2, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants