#1511 add function for initial soc #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1512 +/- ##
===========================================
+ Coverage 98.34% 98.41% +0.06%
===========================================
Files 296 296
Lines 17149 17827 +678
===========================================
+ Hits 16866 17545 +679
+ Misses 283 282 -1
Continue to review full report at Codecov.
|
rtimms
approved these changes
Jun 12, 2021
| self._built_model = None | ||
| self.op_conds_to_built_models = None | ||
|
|
||
| c_n_init = self.parameter_values[ |
There was a problem hiding this comment.
why do you need to get the initial concentrations here?
brosaplanella
approved these changes
Jun 12, 2021
| The initial stoichiometries that give the desired initial state of charge | ||
| """ | ||
| if initial_soc < 0 or initial_soc > 1: | ||
| raise ValueError("Initial SOC should be between 0 and 1") |
There was a problem hiding this comment.
This is currently not tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add function to set initial soc in a simulation
Fixes #1511
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: