-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add script and workflow to update parameter_sets.py #1371
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1371 +/- ##
===========================================
+ Coverage 98.13% 98.25% +0.12%
===========================================
Files 277 277
Lines 15959 15689 -270
===========================================
- Hits 15661 15415 -246
+ Misses 298 274 -24
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @priyanshuone6 , looks great!
Could you add some tests for the update_ps_doc.py
functions (e.g. by breaking up into some sub-functions that can be tested?
Also, using the full parameter_sets
in the name would be clearer than the ps
abbreviation
I have tested it in my fork, please look at the workflow job and pull request created from it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks like it's working well, just a formatting issue to fix and another test to add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @priyanshuone6 , looks good, merging now
@all-contributors add @priyanshuone6 for code |
@tinosulzer I've put up a pull request to add @priyanshuone6! 🎉 |
Description
Add a script to update docstring of
parameter_sets.py
Add a workflow to automatically run the script and make a pull request when modified
Fixes #1033
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: