-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1329 reformat Solution to avoid concatenating y #1331
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1331 +/- ##
========================================
Coverage 98.12% 98.13%
========================================
Files 272 272
Lines 15443 15457 +14
========================================
+ Hits 15154 15169 +15
+ Misses 289 288 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat solution! just a few comments, thanks @tinosulzer !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks Tino!
Description
Reformat
Solution
to avoid concatenatingy
(for performance)Fixes #1329
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: