Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1224 add missing parameters #1226

Merged
merged 1 commit into from
Nov 2, 2020
Merged

#1224 add missing parameters #1226

merged 1 commit into from
Nov 2, 2020

Conversation

valentinsulzer
Copy link
Member

Description

Fixes #1224

@codecov
Copy link

codecov bot commented Nov 2, 2020 •
edited
Loading

Codecov Report

Merging #1226 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1226   +/-   ##
========================================
  Coverage    97.92%   97.92%           
========================================
  Files          249      249           
  Lines        14146    14146           
========================================
  Hits         13852    13852           
  Misses         294      294

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c51df9f...5d9fc81. Read the comment docs.

brosaplanella
brosaplanella approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Tino!

@valentinsulzer valentinsulzer merged commit c5bec9f into develop Nov 2, 2020
@valentinsulzer valentinsulzer deleted the issue-1224-missing-parameters branch November 2, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brosaplanella brosaplanella brosaplanella approved these changes

@rtimms rtimms Awaiting requested review from rtimms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing parameters to Ecker separator
2 participants
@valentinsulzer @brosaplanella