Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sim.t_eval when timescale is function of input #1218

Merged
merged 2 commits into from
Nov 3, 2020

Conversation

TomTranter
Copy link
Contributor

@TomTranter TomTranter commented Oct 29, 2020

Description

Use evaluated timescale from solution when doing sim solve

Fixes #1217

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@TomTranter TomTranter requested a review from rtimms October 29, 2020 11:52
Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @TomTranter , don't forget to update the changelog

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #1218 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1218   +/-   ##
========================================
  Coverage    97.92%   97.92%           
========================================
  Files          249      249           
  Lines        14146    14146           
========================================
  Hits         13852    13852           
  Misses         294      294           
Impacted Files Coverage Δ
pybamm/simulation.py 96.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c51df9f...a6560ec. Read the comment docs.

@TomTranter
Copy link
Contributor Author

Didn't realize we had a changelog!

@TomTranter TomTranter merged commit dd8e5eb into develop Nov 3, 2020
@TomTranter TomTranter deleted the issue-1217-sim_timescale_bug branch November 3, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when solving a simulation with parameter values with inputs that affect the timescale
2 participants