Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Add manylinux wheels for python 3.8 #1202

Merged
merged 9 commits into from
Oct 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/build_wheels_and_publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ jobs:
- name: Build manylinux Python wheels
if: matrix.os == 'ubuntu-latest'
uses: './build_manylinux_wheels'
with:
python-versions: "cp36-cp36m cp37-cp37m cp38-cp38"

- name: Install standard python dependencies
if: matrix.os != 'ubuntu-latest'
Expand All @@ -35,6 +37,10 @@ jobs:
- name: Install build-time deps for MacOS
if: matrix.os == 'macos-latest'
run: |
# Temporary fix for https://github.com/actions/virtual-environments/issues/1811
brew untap local/homebrew-openssl
brew untap local/homebrew-python2
# End of fix
brew update
brew install graphviz
brew install sundials
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/test_on_push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ jobs:
- name: Install MacOS system dependencies
if: matrix.os == 'macos-latest'
run: |
# Temporary fix for https://github.com/actions/virtual-environments/issues/1811
brew untap local/homebrew-openssl
brew untap local/homebrew-python2
# End of fix
brew update
brew install graphviz
brew install openblas
Expand Down
5 changes: 5 additions & 0 deletions build_manylinux_wheels/entrypoint.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
#!/bin/bash
set -e -x

# GitHub runners add "-e LD_LIBRARY_PATH" option to "docker run",
# overriding default value of LD_LIBRARY_PATH in manylinux image. This
# causes libcrypt.so.2 to be missing (it lives in /usr/local/lib)
export LD_LIBRARY_PATH=/usr/local/lib:$LD_LIBRARY_PATH

# CLI arguments
PY_VERSIONS=$1

Expand Down
4 changes: 4 additions & 0 deletions run-tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ def run_code_tests(executable=False, folder: str = "unit", interpreter="python")
tests = "tests/" + folder
if folder == "unit":
pybamm.settings.debug_mode = True
if interpreter == "python":
# Make sure to refer to the interpreter for the
# currently activated virtual environment
interpreter = sys.executable
if executable is False:
suite = unittest.defaultTestLoader.discover(tests, pattern="test*.py")
unittest.TextTestRunner(verbosity=2).run(suite)
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def compile_KLU():

setup(
name="pybamm",
version=load_version() + ".post2",
version=load_version() + ".post3",
description="Python Battery Mathematical Modelling.",
long_description=readme,
long_description_content_type="text/markdown",
Expand Down