Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boundary condition types #1173

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Fix boundary condition types #1173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/notebooks/Creating Models/2-a-pde-model.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
"# boundary conditions\n",
"lbc = pybamm.Scalar(0)\n",
"rbc = pybamm.Scalar(2)\n",
"model.boundary_conditions = {c: {\"left\": (lbc, \"Dirichlet\"), \"right\": (rbc, \"Neumann\")}}"
"model.boundary_conditions = {c: {\"left\": (lbc, \"Neumann\"), \"right\": (rbc, \"Neumann\")}}"
]
},
{
Expand Down
2 changes: 1 addition & 1 deletion examples/notebooks/Creating Models/3-negative-particle-problem.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@
"# boundary conditions \n",
"lbc = pybamm.Scalar(0)\n",
"rbc = -j / F / D\n",
"model.boundary_conditions = {c: {\"left\": (lbc, \"Dirichlet\"), \"right\": (rbc, \"Neumann\")}}\n",
"model.boundary_conditions = {c: {\"left\": (lbc, \"Neumann\"), \"right\": (rbc, \"Neumann\")}}\n",
"\n",
"# initial conditions \n",
"model.initial_conditions = {c: c0}"
Expand Down
2 changes: 1 addition & 1 deletion examples/notebooks/Creating Models/4-comparing-full-and-reduced-order-models.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
"# boundary conditions (only required for full model)\n",
"lbc = pybamm.Scalar(0)\n",
"rbc = -j / F / D\n",
"full_model.boundary_conditions = {c: {\"left\": (lbc, \"Dirichlet\"), \"right\": (rbc, \"Neumann\")}}"
"full_model.boundary_conditions = {c: {\"left\": (lbc, \"Neumann\"), \"right\": (rbc, \"Neumann\")}}"
]
},
{
Expand Down