Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1170 change jnp.max and min to maximum and minimum #1171

Merged
merged 1 commit into from
Sep 16, 2020
Merged

#1170 change jnp.max and min to maximum and minimum #1171

merged 1 commit into from
Sep 16, 2020

Conversation

martinjrobins
Copy link
Contributor

Description

Fixes #1170

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@tlestang tlestang merged commit 87dc41a into develop Sep 16, 2020
@valentinsulzer valentinsulzer deleted the issue-1170-jax-arraylike branch September 22, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlestang tlestang tlestang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jax solver failing tests
2 participants
@martinjrobins @tlestang