Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1096 fix sei typo #1097

Merged
merged 2 commits into from
Jul 1, 2020
Merged

#1096 fix sei typo #1097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ba3538
#1096 fix sei typo
rtimms Jul 1, 2020
e1d956d
#1096 changelog
rtimms Jul 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ This release enables the use of [Google Colab](https://colab.research.google.com

## Bug fixes

- Fixed a bug in `InterstitialDiffusionLimited` ([#1097](https://github.com/pybamm-team/PyBaMM/pull/1097))
- Fixed `Simulation` to keep different copies of the model so that parameters can be changed between simulations ([#1090](https://github.com/pybamm-team/PyBaMM/pull/1090))
- Fixed `model.new_copy()` to keep custom submodels ([#1090](https://github.com/pybamm-team/PyBaMM/pull/1090))
- 2D processed variables can now be evaluated at the domain boundaries ([#1088](https://github.com/pybamm-team/PyBaMM/pull/1088))
Expand Down
3 changes: 2 additions & 1 deletion pybamm/models/submodels/interface/sei/interstitial_diffusion_limited.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,12 @@ def get_coupled_variables(self, variables):
"Inner " + self.domain.lower() + " electrode sei thickness"
]
phi_s_n = variables[self.domain + " electrode potential"]
phi_e_n = variables[self.domain + " electrolyte potential"]

if self.domain == "Negative":
C_sei = self.param.C_sei_inter_n

j_sei = -pybamm.exp(-phi_s_n) / (C_sei * L_sei_inner)
j_sei = -pybamm.exp(-(phi_s_n - phi_e_n)) / (C_sei * L_sei_inner)

alpha = 0.5
j_inner = alpha * j_sei
Expand Down