Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1079 update getting started notebooks #1083

Conversation

brosaplanella
Copy link
Member

Description

I have reformatted the Getting Started notebooks adding some content from the Faraday Tech notebooks.

Fixes #1079

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas

@brosaplanella brosaplanella requested a review from rtimms June 28, 2020 10:21
@codecov
Copy link

codecov bot commented Jun 28, 2020

Codecov Report

Merging #1083 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1083   +/-   ##
========================================
  Coverage    97.77%   97.77%           
========================================
  Files          242      242           
  Lines        12643    12644    +1     
========================================
+ Hits         12362    12363    +1     
  Misses         281      281           
Impacted Files Coverage Δ
pybamm/parameters/parameter_sets.py 100.00% <ø> (ø)
pybamm/solvers/solution.py 99.28% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc5d9f1...3d9390e. Read the comment docs.

Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ferranbrosa looks great! just a few minor comments

@valentinsulzer valentinsulzer merged commit 7f35218 into pybamm-team:develop Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Getting Started notebooks
3 participants