Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1077 update quickplot for fem #1078

Merged
merged 2 commits into from
Jun 24, 2020
Merged

#1077 update quickplot for fem #1078

merged 2 commits into from
Jun 24, 2020

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented Jun 24, 2020

Description

Fixes plots of variables discretised using FEM (y,z) in quickplot

Fixes #1077

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@rtimms rtimms requested a review from brosaplanella June 24, 2020 11:07
Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Rob!

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #1078 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1078   +/-   ##
========================================
  Coverage    97.74%   97.74%           
========================================
  Files          242      242           
  Lines        12528    12532    +4     
========================================
+ Hits         12245    12249    +4     
  Misses         283      283           
Impacted Files Coverage Δ
pybamm/plotting/quick_plot.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7263f0a...baff47b. Read the comment docs.

@rtimms rtimms merged commit 712ed9b into develop Jun 24, 2020
@rtimms rtimms deleted the issue-1077-2Dys-quickplot branch June 24, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2D yz quickplot not quite right
2 participants