Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inputs to function parameters #936

Closed
valentinsulzer opened this issue Apr 2, 2020 · 2 comments · Fixed by #942
Closed

Remove inputs to function parameters #936

valentinsulzer opened this issue Apr 2, 2020 · 2 comments · Fixed by #942
Assignees
@valentinsulzer

Comments

@valentinsulzer
Copy link
Member

Things like "activation energy" and "reference temperature" should be specific to individual functions, and hard-coded into them
@brosaplanella
Copy link
Member

Is that so all those functions are defined as f(c, T) only?

@valentinsulzer
Copy link
Member Author

Yep

@valentinsulzer valentinsulzer self-assigned this Apr 5, 2020
valentinsulzer added a commit that referenced this issue Apr 5, 2020
@valentinsulzer
#936 remove some inputs
d878763
valentinsulzer added a commit that referenced this issue Apr 5, 2020
@valentinsulzer
#936 fix Landesfeind test
877f183
valentinsulzer added a commit that referenced this issue Apr 5, 2020
@valentinsulzer
#936 update docs
d6b1a9e
@valentinsulzer valentinsulzer mentioned this issue Apr 5, 2020
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Apr 5, 2020
@valentinsulzer
#936 changelog [ci skip]
0da83f1
valentinsulzer added a commit that referenced this issue Apr 6, 2020
@valentinsulzer
#936 ferran comments
d6943ec
valentinsulzer added a commit that referenced this issue Apr 6, 2020
@valentinsulzer
Merge pull request #942 from pybamm-team/issue-936-function-inputs
07bfa3e 
#936 remove some inputs
valentinsulzer added a commit that referenced this issue Apr 28, 2020
@valentinsulzer
#936 fix function parameter bug, reduce tol in particle events
14302a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#936 remove some inputs pybamm-team/PyBaMM
2 participants
@valentinsulzer @brosaplanella