Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thermal boundary condition in 1plus1D #711

Closed
rtimms opened this issue Nov 7, 2019 · 0 comments · Fixed by #713
Closed

thermal boundary condition in 1plus1D #711

rtimms opened this issue Nov 7, 2019 · 0 comments · Fixed by #713
Assignees
@rtimms
Labels
bug Something isn't working

Comments

@rtimms
Copy link
Contributor

rtimms commented Nov 7, 2019

when setting boundary conditions by tab in the 1plus1D models if there is a tab at either end, then the right boundary condition gets overridden by the "no tab" condition
@rtimms rtimms added the bug Something isn't working label Nov 7, 2019
@rtimms rtimms self-assigned this Nov 7, 2019
rtimms added a commit that referenced this issue Nov 7, 2019
@rtimms
#711 fix bc bug in 1plus1D
b1b7ffc
@rtimms rtimms mentioned this issue Nov 7, 2019
Merged
8 tasks
rtimms added a commit that referenced this issue Nov 7, 2019
@rtimms
#711 changelog
434f0a1
rtimms added a commit that referenced this issue Nov 8, 2019
@rtimms
#711 improve comments
9e3cf5e
rtimms added a commit that referenced this issue Nov 11, 2019
@rtimms
Merge pull request #713 from pybamm-team/issue-711-thermal-bc-bug
14681fb 
#711 fix bc bug in 1plus1D
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtimms rtimms

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#711 fix bc bug in 1plus1D pybamm-team/PyBaMM
1 participant
@rtimms