-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sequence of jupyter notebooks / other types of documentation for model creation #569
Comments
(e) how to make a reduced order model and compare against the full model |
FYI I've started to add some notebooks based on the exercises from the last training workshop. These will roughly be
Then possibly notebook on turning a model in a class and creating submodel classes, but as @martinjrobins suggests, this might be better as a screen capture. As we discussed the other day, the submodel structure might be a bit intimidating for new users, so I think at this point in time it would be better for the notebooks to focus on creating a model all in the same script/notebook. Let me know if you have any thoughts/input on this. |
Yeah, I agree that the focus should be on creating a model all in a single script. Maybe even including parameters values in that too (instead of using standard_parameters_lithium_ion, at least for the examples, maybe even for when we do a full SPM and/or DFN in a single script). So once we have a full DFN class for example, anyone wanting to add some new physics can just make a copy of that class with the new physics. And when they have finished, we take care of merging it into the submodel structure for them and adding an option to call that submodel, which shouldn't be too bad with all the different parameters and variables already defined (just moving things around). |
Summary
a sequence of online tutorials (notebooks or other) going from creating simple to more complicated models in pybamm.
Motivation
Try to ease new users into the pybamm framework, focusing in particular on users interested in model development
Potential list of tutorials
(a) create an ode model
(b) create a pde model
(c) create a model class (maybe better as a video / screen capture rather than a notebook?)
(d) create a new submodel
The text was updated successfully, but these errors were encountered: