Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sto*0 from solid diffusivity functions #547

Closed
Scottmar93 opened this issue Jul 23, 2019 · 2 comments · Fixed by #724
Closed

Remove sto*0 from solid diffusivity functions #547

Scottmar93 opened this issue Jul 23, 2019 · 2 comments · Fixed by #724

Comments

@Scottmar93
Copy link
Contributor

I just put a hack of sto*0 into the solid diffusion functions for now to satisfy the shape tests. We should refactor shape tests for functions so that this does not need to be done.
@valentinsulzer
Copy link
Member

Fixed in #546 :)

valentinsulzer added a commit that referenced this issue Jul 23, 2019
@valentinsulzer
#546 do fix for #547
ba4dee3
@valentinsulzer
Copy link
Member

Turns out this fails later on :(
Would require changing Addition._binary_simplify to maintain the shape in the case where we have Matrix(0) + Scalar(not zero). Not going to do this right now.

rtimms added a commit that referenced this issue Nov 12, 2019
@rtimms
#547 remove sto times zero
1466968
@rtimms rtimms mentioned this issue Nov 12, 2019
Merged
8 tasks
rtimms added a commit that referenced this issue Nov 13, 2019
@rtimms
Merge pull request #724 from pybamm-team/issue-547-sto-times-zero
f06675b 
#547 remove sto times zero
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#547 remove sto times zero pybamm-team/PyBaMM
2 participants
@valentinsulzer @Scottmar93