Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empirical hysteresis #3161

Closed
rtimms opened this issue Jul 19, 2023 · 0 comments · Fixed by #3194
Closed

Empirical hysteresis #3161

rtimms opened this issue Jul 19, 2023 · 0 comments · Fixed by #3194
Assignees
Labels
difficulty: medium Will take a few days priority: medium To be resolved if time allows

Comments

@rtimms
Copy link
Contributor

rtimms commented Jul 19, 2023

We currently support an empirical “current sigmoid” model for OCV hysteresis, where users can give a lithiation and delithiation OCV and switch between them depending on the sign of the current. Including such a model has knock-on effects for other model parameters, which may also need to be depend on the sign of the current in order to accurately fit experimental data. In particular, we should add empirical hysteresis for exchange-current and diffusivity.

Longer term we plan to add more sophisticated and self-consistent hysteresis models, but this is a good pragmatic solution for now.

@rtimms rtimms added difficulty: medium Will take a few days priority: medium To be resolved if time allows labels Jul 19, 2023
@rtimms rtimms self-assigned this Jul 19, 2023
rtimms added a commit that referenced this issue Jul 27, 2023
valentinsulzer added a commit that referenced this issue Jul 28, 2023
…esis

#3161 add emperical hysteresis for exchange-current and diffusivity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium Will take a few days priority: medium To be resolved if time allows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant