Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ParameterizedModel and DiscretizedModel #2382

Open
valentinsulzer opened this issue Oct 19, 2022 · 0 comments
Open

Add ParameterizedModel and DiscretizedModel #2382

valentinsulzer opened this issue Oct 19, 2022 · 0 comments
Assignees
@valentinsulzer
Labels
difficulty: medium Will take a few days

Comments

@valentinsulzer
Copy link
Member

To be generated by the parameterization and discretization classes respectively

These should be "read-only" models, i.e. once they are initialized it should not be possible to update the rhs, initial conditions, variables, etc

We can also move functions from BaseModel that are specific to discretized or parameterized models
@valentinsulzer valentinsulzer added the difficulty: medium Will take a few days label Oct 19, 2022
@valentinsulzer valentinsulzer self-assigned this Oct 19, 2022
valentinsulzer added a commit that referenced this issue Oct 20, 2022
@valentinsulzer
#2382 separating model classes
5424441
valentinsulzer added a commit that referenced this issue Oct 20, 2022
@valentinsulzer
#2382 SPMe example working
c9bda6c
valentinsulzer added a commit that referenced this issue Oct 20, 2022
@valentinsulzer
#2382 merge remove-unused-function
f4dd305
@valentinsulzer valentinsulzer mentioned this issue Oct 20, 2022
Closed
8 tasks
valentinsulzer added a commit that referenced this issue Oct 20, 2022
@valentinsulzer
#2382 working on tests
5cdc7c5
valentinsulzer added a commit that referenced this issue Oct 20, 2022
@valentinsulzer
#2382 tests
8d866d5
valentinsulzer added a commit that referenced this issue Oct 21, 2022
@valentinsulzer
#2382 refactor Simulation class
f3f7016
valentinsulzer added a commit that referenced this issue Oct 21, 2022
@valentinsulzer
#2382 getting experiment to work
14cdfff
valentinsulzer added a commit that referenced this issue Oct 21, 2022
@valentinsulzer
#2382 working on reformatting simulation and experiment
b01db4b
valentinsulzer added a commit that referenced this issue Oct 21, 2022
@valentinsulzer
#2382 working on tests
f79ae87
valentinsulzer added a commit that referenced this issue Oct 21, 2022
@valentinsulzer
#2382 fix simulations with experiments
bfb4374
valentinsulzer added a commit that referenced this issue Oct 21, 2022
@valentinsulzer
#2382 flake8
0df3a59
valentinsulzer added a commit that referenced this issue Oct 21, 2022
@valentinsulzer
#2382 merge issue-2382-simulation-only
4ec21f3
valentinsulzer added a commit that referenced this issue Oct 21, 2022
@valentinsulzer
#2382 fix coverage and integration tests
7824e56
valentinsulzer added a commit that referenced this issue Oct 21, 2022
@valentinsulzer
#2382 fix examples
b8f1734
valentinsulzer added a commit that referenced this issue Oct 24, 2022
@valentinsulzer
#2382 flake8
177397a
valentinsulzer added a commit that referenced this issue Nov 20, 2022
@valentinsulzer
#2382 merge develop
43afef6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
difficulty: medium Will take a few days
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 2382 separate model classes pybamm-team/PyBaMM
1 participant
@valentinsulzer