Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise Error if Concatenation is used with Variables #1768

Closed
valentinsulzer opened this issue Oct 30, 2021 · 0 comments · Fixed by #1789
Closed

Raise Error if Concatenation is used with Variables #1768

valentinsulzer opened this issue Oct 30, 2021 · 0 comments · Fixed by #1789

Comments

@valentinsulzer
Copy link
Member

ConcatenationVariable should be used instead. This is handled automatically by the concanteation function
valentinsulzer added a commit that referenced this issue Nov 8, 2021
@valentinsulzer
#1768 add error message for Concatenation
36eab78
valentinsulzer added a commit that referenced this issue Nov 8, 2021
@valentinsulzer
#1768 use issubclass
faf95cf
valentinsulzer added a commit that referenced this issue Nov 8, 2021
@valentinsulzer
#1768 revert tol changes
9edf2c1
@valentinsulzer valentinsulzer mentioned this issue Nov 8, 2021
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Nov 8, 2021
@valentinsulzer
#1768 changelog
2e37286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 1768 concat pybamm-team/PyBaMM
1 participant
@valentinsulzer