Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "concentration" variable with "porosity times concentration" #1456

Closed
valentinsulzer opened this issue Apr 5, 2021 · 0 comments · Fixed by #1476
Closed

Replace "concentration" variable with "porosity times concentration" #1456

valentinsulzer opened this issue Apr 5, 2021 · 0 comments · Fixed by #1476
Assignees
@valentinsulzer

Comments

@valentinsulzer
Copy link
Member

Since "porosity times concentration" is actually what is conserved in the electrolyte diffusion equation, it might make more sense to have that be the variable, instead of "concentration"
@valentinsulzer valentinsulzer self-assigned this Apr 5, 2021
valentinsulzer added a commit that referenced this issue Apr 30, 2021
@valentinsulzer
#1456 changed variable, need to resolve order
a4f0d0c
valentinsulzer added a commit that referenced this issue Apr 30, 2021
@valentinsulzer
#1456 debugging
2cd0bb3
valentinsulzer added a commit that referenced this issue Apr 30, 2021
@valentinsulzer
#1456 compare_lithium_ion now works
865c32e
valentinsulzer added a commit that referenced this issue May 2, 2021
@valentinsulzer
#1456 fix tests
078e445
valentinsulzer added a commit that referenced this issue May 3, 2021
@valentinsulzer
#1456 fix example
9cb7cf0
valentinsulzer added a commit that referenced this issue May 3, 2021
@valentinsulzer
#1456 fix test
99ccde2
@valentinsulzer valentinsulzer mentioned this issue May 3, 2021
Merged
8 tasks
valentinsulzer added a commit that referenced this issue May 4, 2021
@valentinsulzer
#1456 changelog
dfe802d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 1456 concentration pybamm-team/PyBaMM
1 participant
@valentinsulzer