Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify JAX bdf solver to allow solution of semi-explicit DAEs #1104

Closed
martinjrobins opened this issue Jul 11, 2020 · 0 comments · Fixed by #1107
Closed

modify JAX bdf solver to allow solution of semi-explicit DAEs #1104

martinjrobins opened this issue Jul 11, 2020 · 0 comments · Fixed by #1107
Assignees
@martinjrobins

Comments

@martinjrobins
Copy link
Contributor

martinjrobins commented Jul 11, 2020 •
edited
Loading

Summary
Matlab allows for ode15s to solve semi-explicit DAEs by solving the equivalent ODE using a singular mass matrix. Need to modify the Jax BDF solver to do the same

Motivation
So JAX BDF solver can solve semi-explicit DAEs (i.e. all DAE models in Pybamm). Currently limited to ODEs

References

[1] Shampine, L. F. and M. W. Reichelt, “The MATLAB ODE Suite,” SIAM Journal on Scientific Computing, Vol. 18, 1997, pp. 1–22.

See also comments by @tinosulzer in #1038
@martinjrobins martinjrobins self-assigned this Jul 11, 2020
martinjrobins added a commit that referenced this issue Jul 12, 2020
@martinjrobins
#1104 debugging for incorporation of mass matrix
d724ee4
martinjrobins added a commit that referenced this issue Jul 12, 2020
@martinjrobins
#1104 fix scaling of newton iteration
76d327e
martinjrobins added a commit that referenced this issue Jul 13, 2020
@martinjrobins
#1104 add test in jax solver for semi-explicit dae case
1f691df
martinjrobins added a commit that referenced this issue Jul 13, 2020
@martinjrobins
#1104 tidy up
de4846e
martinjrobins added a commit that referenced this issue Jul 13, 2020
@martinjrobins
#1104 debugging for incorporation of mass matrix
c91f123
martinjrobins added a commit that referenced this issue Jul 13, 2020
@martinjrobins
#1104 fix scaling of newton iteration
9b23870
martinjrobins added a commit that referenced this issue Jul 13, 2020
@martinjrobins
#1104 add test in jax solver for semi-explicit dae case
cc46590
martinjrobins added a commit that referenced this issue Jul 13, 2020
@martinjrobins
#1104 tidy up
08d811b
@martinjrobins martinjrobins mentioned this issue Jul 13, 2020
Merged
6 tasks
martinjrobins added a commit that referenced this issue Jul 13, 2020
@martinjrobins
#1104 debugging for incorporation of mass matrix
4281a5e
martinjrobins added a commit that referenced this issue Jul 13, 2020
@martinjrobins
#1104 fix scaling of newton iteration
be1f030
martinjrobins added a commit that referenced this issue Jul 13, 2020
@martinjrobins
#1104 add test in jax solver for semi-explicit dae case
beb9bad
martinjrobins added a commit that referenced this issue Jul 13, 2020
@martinjrobins
#1104 tidy up
ec0ab2b
martinjrobins added a commit that referenced this issue Jul 13, 2020
@martinjrobins
#1104 debugging for incorporation of mass matrix
a42f4e5
martinjrobins added a commit that referenced this issue Jul 13, 2020
@martinjrobins
#1104 fix scaling of newton iteration
5f2db7c
martinjrobins added a commit that referenced this issue Jul 13, 2020
@martinjrobins
#1104 add test in jax solver for semi-explicit dae case
81eb538
martinjrobins added a commit that referenced this issue Jul 13, 2020
@martinjrobins
#1104 tidy up
107f7ce
martinjrobins added a commit that referenced this issue Jul 13, 2020
@martinjrobins
#1104 jax bdf solver calculates own consistent initial conditions for…
1bdb5fd 
… semi-explicit dae models
martinjrobins added a commit that referenced this issue Jul 14, 2020
@martinjrobins
#1104 remove cond in update_step_size
df5326a
martinjrobins added a commit that referenced this issue Jul 14, 2020
@martinjrobins
#1104 remove cond in newton iteration
c4c4c66
martinjrobins added a commit that referenced this issue Jul 14, 2020
@martinjrobins
#1104 get rid of lax.cond calls in bdf solver
0ca87c4
martinjrobins added a commit that referenced this issue Jul 14, 2020
@martinjrobins
#1104 fix flake8 and some minor bugs
3e31c5f
martinjrobins added a commit that referenced this issue Jul 14, 2020
@martinjrobins
#1104 improve coverage
4e3a78b
martinjrobins added a commit that referenced this issue Jul 14, 2020
@martinjrobins
#1104 merge develop
acc8314
martinjrobins added a commit that referenced this issue Jul 15, 2020
@martinjrobins
#1104 put in proper adjoint equations for semi-explicit dae index 1
f08dc57
martinjrobins added a commit that referenced this issue Jul 15, 2020
@martinjrobins
#1104 allow users to choose alternate root method to set initial cond…
016e12d 
…itions
martinjrobins added a commit that referenced this issue Jul 15, 2020
@martinjrobins
#1104 add changelog
71cfee6
martinjrobins added a commit that referenced this issue Jul 15, 2020
@martinjrobins
#1104 handle augmented dynamics with inputs
dd8180d
martinjrobins added a commit that referenced this issue Jul 15, 2020
@martinjrobins
#1104 fix for newton iteration logic
6776638
martinjrobins added a commit that referenced this issue Jul 15, 2020
@martinjrobins
#1104 fix calc of init conditions
957611e
martinjrobins added a commit that referenced this issue Jul 16, 2020
@martinjrobins
#1104 convert to diagonal mass matrix
02bfd2c
martinjrobins added a commit that referenced this issue Jul 16, 2020
@martinjrobins
#1104 swap back to full mass matrix
b35019b
martinjrobins added a commit that referenced this issue Jul 19, 2020
@martinjrobins
#1104 remove commented out code
6a85083
martinjrobins added a commit that referenced this issue Jul 19, 2020
@martinjrobins
#1104 add jax bdf solver to compare-dae-solver
1cd40f8
martinjrobins added a commit that referenced this issue Jul 20, 2020
@martinjrobins
Revert "#1104 add jax bdf solver to compare-dae-solver"
9ceabe2 
This reverts commit 1cd40f8.
martinjrobins added a commit that referenced this issue Jul 20, 2020
@martinjrobins
#1104 more detail to changelog
f6c51f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinjrobins martinjrobins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 1104 mass matrix for bdf pybamm-team/PyBaMM
1 participant
@martinjrobins