Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

j_sei in interstitial_diffusion_limited #1096

Closed
rtimms opened this issue Jul 1, 2020 · 0 comments · Fixed by #1097
Closed

j_sei in interstitial_diffusion_limited #1096

rtimms opened this issue Jul 1, 2020 · 0 comments · Fixed by #1097
Assignees
@rtimms
Labels
bug Something isn't working

Comments

@rtimms
Copy link
Contributor

rtimms commented Jul 1, 2020

There is a typo in the model on line 41 of interstitial_diffusion_limited.py It should read: j_sei = -pybamm.exp(-(phi_s_n-phi_e_n) ) / (C_sei * L_sei_inner)
@rtimms rtimms added the bug Something isn't working label Jul 1, 2020
@rtimms rtimms self-assigned this Jul 1, 2020
rtimms added a commit that referenced this issue Jul 1, 2020
@rtimms
#1096 fix sei typo
8ba3538
@rtimms rtimms mentioned this issue Jul 1, 2020
Merged
8 tasks
rtimms added a commit that referenced this issue Jul 1, 2020
@rtimms
#1096 changelog
e1d956d
valentinsulzer added a commit that referenced this issue Jul 1, 2020
@valentinsulzer
Merge pull request #1097 from pybamm-team/issue-1096-sei-bug
56c0383 
#1096 fix sei typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtimms rtimms

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1096 fix sei typo pybamm-team/PyBaMM
1 participant
@rtimms