Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running a simulation with a discretized model #1023

Closed
valentinsulzer opened this issue May 26, 2020 · 0 comments · Fixed by #1025
Closed

Running a simulation with a discretized model #1023

valentinsulzer opened this issue May 26, 2020 · 0 comments · Fixed by #1025
Assignees
@valentinsulzer

Comments

@valentinsulzer
Copy link
Member

Describe the bug
If a user discretizes a model manually then passes it to a simulation, the simulation fails when trying to process parameters

Expected behaviour
The simulation should recognize that the model has been discretized already
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1023 add case for already discretised model pybamm-team/PyBaMM
1 participant
@valentinsulzer