Merge pull request #1397 from pybamm-team/ec-sei-bug

Ec sei bug
pybamm-team · Mar 1, 2021 · 62610a5 · 62610a5
2 parents 9a95deb + 7ffd0ca
commit 62610a5
Show file tree

Hide file tree

Showing 51 changed files with 503 additions and 512 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -32,6 +32,7 @@
 ## Bug fixes
 
 -   Fixed a sign error in the positive electrode ohmic losses ([#1407](https://github.com/pybamm-team/PyBaMM/pull/1407))
+-   Fixed the formulation of the EC reaction SEI model ([#1397](https://github.com/pybamm-team/PyBaMM/pull/1397))
 -   Simulations now stop when an experiment becomes infeasible ([#1395](https://github.com/pybamm-team/PyBaMM/pull/1395))
 -   Added a check for domains in `Concatenation` ([#1368](https://github.com/pybamm-team/PyBaMM/pull/1368))
 -   Differentiation now works even when the differentiation variable is a constant ([#1294](https://github.com/pybamm-team/PyBaMM/pull/1294))

diff --git a/examples/notebooks/Getting Started/Tutorial 3 - Basic plotting.ipynb b/examples/notebooks/Getting Started/Tutorial 3 - Basic plotting.ipynb
@@ -310,70 +310,70 @@
        " 'Volume-averaged cell temperature [K]',\n",
        " 'Ambient temperature [K]',\n",
        " 'Ambient temperature',\n",
-       " 'Inner negative electrode sei thickness',\n",
-       " 'Inner negative electrode sei thickness [m]',\n",
-       " 'X-averaged inner negative electrode sei thickness',\n",
-       " 'X-averaged inner negative electrode sei thickness [m]',\n",
-       " 'Outer negative electrode sei thickness',\n",
-       " 'Outer negative electrode sei thickness [m]',\n",
-       " 'X-averaged outer negative electrode sei thickness',\n",
-       " 'X-averaged outer negative electrode sei thickness [m]',\n",
-       " 'Total negative electrode sei thickness',\n",
-       " 'Total negative electrode sei thickness [m]',\n",
-       " 'X-averaged total negative electrode sei thickness',\n",
-       " 'X-averaged total negative electrode sei thickness [m]',\n",
+       " 'Inner negative electrode SEI thickness',\n",
+       " 'Inner negative electrode SEI thickness [m]',\n",
+       " 'X-averaged inner negative electrode SEI thickness',\n",
+       " 'X-averaged inner negative electrode SEI thickness [m]',\n",
+       " 'Outer negative electrode SEI thickness',\n",
+       " 'Outer negative electrode SEI thickness [m]',\n",
+       " 'X-averaged outer negative electrode SEI thickness',\n",
+       " 'X-averaged outer negative electrode SEI thickness [m]',\n",
+       " 'Total negative electrode SEI thickness',\n",
+       " 'Total negative electrode SEI thickness [m]',\n",
+       " 'X-averaged total negative electrode SEI thickness',\n",
+       " 'X-averaged total negative electrode SEI thickness [m]',\n",
        " 'X-averaged negative electrode resistance [Ohm.m2]',\n",
-       " 'Inner negative electrode sei concentration [mol.m-3]',\n",
-       " 'X-averaged inner negative electrode sei concentration [mol.m-3]',\n",
-       " 'Outer negative electrode sei concentration [mol.m-3]',\n",
-       " 'X-averaged outer negative electrode sei concentration [mol.m-3]',\n",
-       " 'Negative sei concentration [mol.m-3]',\n",
-       " 'X-averaged negative electrode sei concentration [mol.m-3]',\n",
-       " 'Loss of lithium to negative electrode sei [mol]',\n",
-       " 'Inner negative electrode sei interfacial current density',\n",
-       " 'Inner negative electrode sei interfacial current density [A.m-2]',\n",
-       " 'X-averaged inner negative electrode sei interfacial current density',\n",
-       " 'X-averaged inner negative electrode sei interfacial current density [A.m-2]',\n",
-       " 'Outer negative electrode sei interfacial current density',\n",
-       " 'Outer negative electrode sei interfacial current density [A.m-2]',\n",
-       " 'X-averaged outer negative electrode sei interfacial current density',\n",
-       " 'X-averaged outer negative electrode sei interfacial current density [A.m-2]',\n",
-       " 'Negative electrode sei interfacial current density',\n",
-       " 'Negative electrode sei interfacial current density [A.m-2]',\n",
-       " 'X-averaged negative electrode sei interfacial current density',\n",
-       " 'X-averaged negative electrode sei interfacial current density [A.m-2]',\n",
-       " 'Inner positive electrode sei thickness',\n",
-       " 'Inner positive electrode sei thickness [m]',\n",
-       " 'X-averaged inner positive electrode sei thickness',\n",
-       " 'X-averaged inner positive electrode sei thickness [m]',\n",
-       " 'Outer positive electrode sei thickness',\n",
-       " 'Outer positive electrode sei thickness [m]',\n",
-       " 'X-averaged outer positive electrode sei thickness',\n",
-       " 'X-averaged outer positive electrode sei thickness [m]',\n",
-       " 'Total positive electrode sei thickness',\n",
-       " 'Total positive electrode sei thickness [m]',\n",
-       " 'X-averaged total positive electrode sei thickness',\n",
-       " 'X-averaged total positive electrode sei thickness [m]',\n",
+       " 'Inner negative electrode SEI concentration [mol.m-3]',\n",
+       " 'X-averaged inner negative electrode SEI concentration [mol.m-3]',\n",
+       " 'Outer negative electrode SEI concentration [mol.m-3]',\n",
+       " 'X-averaged outer negative electrode SEI concentration [mol.m-3]',\n",
+       " 'Negative SEI concentration [mol.m-3]',\n",
+       " 'X-averaged negative electrode SEI concentration [mol.m-3]',\n",
+       " 'Loss of lithium to negative electrode SEI [mol]',\n",
+       " 'Inner negative electrode SEI interfacial current density',\n",
+       " 'Inner negative electrode SEI interfacial current density [A.m-2]',\n",
+       " 'X-averaged inner negative electrode SEI interfacial current density',\n",
+       " 'X-averaged inner negative electrode SEI interfacial current density [A.m-2]',\n",
+       " 'Outer negative electrode SEI interfacial current density',\n",
+       " 'Outer negative electrode SEI interfacial current density [A.m-2]',\n",
+       " 'X-averaged outer negative electrode SEI interfacial current density',\n",
+       " 'X-averaged outer negative electrode SEI interfacial current density [A.m-2]',\n",
+       " 'Negative electrode SEI interfacial current density',\n",
+       " 'Negative electrode SEI interfacial current density [A.m-2]',\n",
+       " 'X-averaged negative electrode SEI interfacial current density',\n",
+       " 'X-averaged negative electrode SEI interfacial current density [A.m-2]',\n",
+       " 'Inner positive electrode SEI thickness',\n",
+       " 'Inner positive electrode SEI thickness [m]',\n",
+       " 'X-averaged inner positive electrode SEI thickness',\n",
+       " 'X-averaged inner positive electrode SEI thickness [m]',\n",
+       " 'Outer positive electrode SEI thickness',\n",
+       " 'Outer positive electrode SEI thickness [m]',\n",
+       " 'X-averaged outer positive electrode SEI thickness',\n",
+       " 'X-averaged outer positive electrode SEI thickness [m]',\n",
+       " 'Total positive electrode SEI thickness',\n",
+       " 'Total positive electrode SEI thickness [m]',\n",
+       " 'X-averaged total positive electrode SEI thickness',\n",
+       " 'X-averaged total positive electrode SEI thickness [m]',\n",
        " 'X-averaged positive electrode resistance [Ohm.m2]',\n",
-       " 'Inner positive electrode sei concentration [mol.m-3]',\n",
-       " 'X-averaged inner positive electrode sei concentration [mol.m-3]',\n",
-       " 'Outer positive electrode sei concentration [mol.m-3]',\n",
-       " 'X-averaged outer positive electrode sei concentration [mol.m-3]',\n",
-       " 'Positive sei concentration [mol.m-3]',\n",
-       " 'X-averaged positive electrode sei concentration [mol.m-3]',\n",
-       " 'Loss of lithium to positive electrode sei [mol]',\n",
-       " 'Inner positive electrode sei interfacial current density',\n",
-       " 'Inner positive electrode sei interfacial current density [A.m-2]',\n",
-       " 'X-averaged inner positive electrode sei interfacial current density',\n",
-       " 'X-averaged inner positive electrode sei interfacial current density [A.m-2]',\n",
-       " 'Outer positive electrode sei interfacial current density',\n",
-       " 'Outer positive electrode sei interfacial current density [A.m-2]',\n",
-       " 'X-averaged outer positive electrode sei interfacial current density',\n",
-       " 'X-averaged outer positive electrode sei interfacial current density [A.m-2]',\n",
-       " 'Positive electrode sei interfacial current density',\n",
-       " 'Positive electrode sei interfacial current density [A.m-2]',\n",
-       " 'X-averaged positive electrode sei interfacial current density',\n",
-       " 'X-averaged positive electrode sei interfacial current density [A.m-2]',\n",
+       " 'Inner positive electrode SEI concentration [mol.m-3]',\n",
+       " 'X-averaged inner positive electrode SEI concentration [mol.m-3]',\n",
+       " 'Outer positive electrode SEI concentration [mol.m-3]',\n",
+       " 'X-averaged outer positive electrode SEI concentration [mol.m-3]',\n",
+       " 'Positive SEI concentration [mol.m-3]',\n",
+       " 'X-averaged positive electrode SEI concentration [mol.m-3]',\n",
+       " 'Loss of lithium to positive electrode SEI [mol]',\n",
+       " 'Inner positive electrode SEI interfacial current density',\n",
+       " 'Inner positive electrode SEI interfacial current density [A.m-2]',\n",
+       " 'X-averaged inner positive electrode SEI interfacial current density',\n",
+       " 'X-averaged inner positive electrode SEI interfacial current density [A.m-2]',\n",
+       " 'Outer positive electrode SEI interfacial current density',\n",
+       " 'Outer positive electrode SEI interfacial current density [A.m-2]',\n",
+       " 'X-averaged outer positive electrode SEI interfacial current density',\n",
+       " 'X-averaged outer positive electrode SEI interfacial current density [A.m-2]',\n",
+       " 'Positive electrode SEI interfacial current density',\n",
+       " 'Positive electrode SEI interfacial current density [A.m-2]',\n",
+       " 'X-averaged positive electrode SEI interfacial current density',\n",
+       " 'X-averaged positive electrode SEI interfacial current density [A.m-2]',\n",
        " 'Electrolyte tortuosity',\n",
        " 'Negative electrolyte tortuosity',\n",
        " 'Positive electrolyte tortuosity',\n",
@@ -483,10 +483,10 @@
        " 'X-averaged negative electrode open circuit potential [V]',\n",
        " 'Negative electrode entropic change',\n",
        " 'X-averaged negative electrode entropic change',\n",
-       " 'Negative electrode sei film overpotential',\n",
-       " 'X-averaged negative electrode sei film overpotential',\n",
-       " 'Negative electrode sei film overpotential [V]',\n",
-       " 'X-averaged negative electrode sei film overpotential [V]',\n",
+       " 'Negative electrode SEI film overpotential',\n",
+       " 'X-averaged negative electrode SEI film overpotential',\n",
+       " 'Negative electrode SEI film overpotential [V]',\n",
+       " 'X-averaged negative electrode SEI film overpotential [V]',\n",
        " 'Positive electrode interfacial current density',\n",
        " 'X-averaged positive electrode interfacial current density',\n",
        " 'Positive electrode interfacial current density [A.m-2]',\n",
@@ -512,10 +512,10 @@
        " 'X-averaged positive electrode open circuit potential [V]',\n",
        " 'Positive electrode entropic change',\n",
        " 'X-averaged positive electrode entropic change',\n",
-       " 'Positive electrode sei film overpotential',\n",
-       " 'X-averaged positive electrode sei film overpotential',\n",
-       " 'Positive electrode sei film overpotential [V]',\n",
-       " 'X-averaged positive electrode sei film overpotential [V]',\n",
+       " 'Positive electrode SEI film overpotential',\n",
+       " 'X-averaged positive electrode SEI film overpotential',\n",
+       " 'Positive electrode SEI film overpotential [V]',\n",
+       " 'X-averaged positive electrode SEI film overpotential [V]',\n",
        " 'Interfacial current density',\n",
        " 'Interfacial current density [A.m-2]',\n",
        " 'Interfacial current density per volume [A.m-3]',\n",
@@ -583,8 +583,8 @@
        " 'Measured open circuit voltage [V]',\n",
        " 'X-averaged reaction overpotential',\n",
        " 'X-averaged reaction overpotential [V]',\n",
-       " 'X-averaged sei film overpotential',\n",
-       " 'X-averaged sei film overpotential [V]',\n",
+       " 'X-averaged SEI film overpotential',\n",
+       " 'X-averaged SEI film overpotential [V]',\n",
        " 'X-averaged solid phase ohmic losses',\n",
        " 'X-averaged solid phase ohmic losses [V]',\n",
        " 'X-averaged battery open circuit voltage [V]',\n",