Merge pull request #1773 from dion-w/issue-1734-fix-solid-tortuosity

solid tau now uses correct bruggeman coeff
pybamm-team · Dec 2, 2021 · 022100a · 022100a
2 parents 15992b3 + 203c350
commit 022100a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+# [Unreleased](https://github.com/pybamm-team/PyBaMM/) - 2021-12-01
+
+## Bug fixes
+- Solid tortuosity is now correctly calculated with Bruggeman coefficient of the respective electrode ([#1773](https://github.com/pybamm-team/PyBaMM/pull/1773))
+
 # [v21.11](https://github.com/pybamm-team/PyBaMM/tree/v21.11) - 2021-11-30
 
 ## Features

diff --git a/examples/notebooks/parameterization/parameterization.ipynb b/examples/notebooks/parameterization/parameterization.ipynb
@@ -1616,6 +1616,7 @@
     " 'Negative electrode active material volume fraction': 0.75,\n",
     " 'Negative particle radius [m]': 5.86e-06,\n",
     " 'Negative electrode Bruggeman coefficient (electrolyte)': 1.5,\n",
+    " 'Negative electrode Bruggeman coefficient (electrode)': 1.5,\n",
     " 'Negative electrode electrons in reaction': 1.0,\n",
     " 'Negative electrode exchange-current density [A.m-2]': graphite_LGM50_electrolyte_exchange_current_density_Chen2020,\n",
     " 'Negative electrode OCP entropic change [V.K-1]': 0.0,\n",
@@ -1626,6 +1627,7 @@
     " 'Positive electrode active material volume fraction': 0.665,\n",
     " 'Positive particle radius [m]': 5.22e-06,\n",
     " 'Positive electrode Bruggeman coefficient (electrolyte)': 1.5,\n",
+    " 'Positive electrode Bruggeman coefficient (electrode)': 1.5,\n",
     " 'Positive electrode electrons in reaction': 1.0,\n",
     " 'Positive electrode exchange-current density [A.m-2]': nmc_LGM50_electrolyte_exchange_current_density_Chen2020,\n",
     " 'Positive electrode OCP entropic change [V.K-1]': 0.0,\n",

diff --git a/pybamm/models/submodels/tortuosity/bruggeman_tortuosity.py b/pybamm/models/submodels/tortuosity/bruggeman_tortuosity.py
@@ -44,11 +44,11 @@ def get_coupled_variables(self, variables):
                 tor_n = None
             else:
                 eps_n = variables["Negative electrode active material volume fraction"]
-                tor_n = eps_n ** param.b_e_n
+                tor_n = eps_n ** param.b_s_n
 
             eps_p = variables["Positive electrode active material volume fraction"]
             tor_s = pybamm.FullBroadcast(0, "separator", "current collector")
-            tor_p = eps_p ** param.b_e_p
+            tor_p = eps_p ** param.b_s_p
 
         variables.update(
             self._get_standard_tortuosity_variables(