Improve usability by adoptiny an alternative Base32 charset #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit propose to use the charset ABCDEFGHJKLMNPQRSTUVWXYZ23456789 in place of ABCDEFGHIJKLMNOPQRSTUVWXYZ234567. The proposed charset is more usable as it do not contain any character in the set [O, 0, I, 1]
18 tasks
|
Thanks for the PR. This is a good idea, unfortunately it is outside the scope of this library because using such an alphabet would make PyOTP inconsistent with the key URI format specification (https://github.com/google/google-authenticator/wiki/Key-Uri-Format#secret) and incompatible with other OTP implementations. Specifically, the key URI format spec mandates the use of the default RFC 3548 base32 alphabet without padding. |
|
Thank you @kislyuk; yep @zenmonkeykstop noticed the same and i was about to close this pull myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit propose to use the charset ABCDEFGHJKLMNPQRSTUVWXYZ23456789 in place of ABCDEFGHIJKLMNOPQRSTUVWXYZ234567.
The proposed charset is more usable as it do not contain any character in the set [O, 0, I, 1]