Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't reuse text in qcollapsible #204

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Sep 23, 2023

fixes #203

not quite sure why that was like that ... might have been a combination of #140 not updating #37?
but i think it's fine just to remove it

@coderabbitai
Copy link

coderabbitai bot commented Sep 23, 2023

Walkthrough

The proposed change simplifies the setText method in a toggle button class. It enhances readability by directly setting the text instead of appending it to the existing one, without altering the method's behavior.

Changes

File Summary
.../superqt/collapsible/_collapsible.py The setText method of the toggle button class has been simplified. It now directly sets the text rather than appending it to the current text. This improves clarity and removes unnecessary code while maintaining the same functionality.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 409d19e and 79555b0.
Files selected for processing (1)
  • src/superqt/collapsible/_collapsible.py (1 hunks)
Files skipped from review due to trivial changes (1)
  • src/superqt/collapsible/_collapsible.py

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (409d19e) 87.30% compared to head (79555b0) 87.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
- Coverage   87.30%   87.30%   -0.01%     
==========================================
  Files          45       45              
  Lines        3324     3323       -1     
==========================================
- Hits         2902     2901       -1     
  Misses        422      422              
Files Changed Coverage Δ
src/superqt/collapsible/_collapsible.py 94.73% <100.00%> (-0.05%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit 0b984c2 into pyapp-kit:main Sep 24, 2023
42 checks passed
@tlambert03 tlambert03 deleted the fix-collapse branch September 24, 2023 19:07
@tlambert03 tlambert03 added the bug Something isn't working label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Setting Text in Collapsible Adds to text instead of replacing
1 participant