-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port base item model for SelectableEventedList
backed ListView
from napari
#105
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 85.30% // Head: 81.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
- Coverage 85.30% 81.83% -3.48%
==========================================
Files 31 34 +3
Lines 2607 2719 +112
==========================================
+ Hits 2224 2225 +1
- Misses 383 494 +111
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
hey @alisterburt ... man, I swear I commented on this before, but I guess not 😂 |
Ello ello! Thanks for the ping and sorry for shelving this for so long, the curse of trying to contribute things I don't strictly need 😆 I've got a bit of time now so will move the tests over 🙂 |
might be being stupid but the only tests I could see were the listmodel test so I ported that over and fixed a minor bug. I likely won't have much more time for this in the next few days so please feel free to push it over the line if you have momentum! |
thanks for what you did! :) |
This PR ports the
_BaseEventedItemModel
, an adapter between theQAbstractItemModel
and ourSelectableEventedList
, from napari to superqt. This is a first step towards a psygnal backedQtListView
in superqtOriginal code in napari: https://github.com/napari/napari/blob/main/napari/_qt/containers/_base_item_model.py
The code has been updated to work with the psygnal
SelectableEventedList
, requiring only minimal changes.I didn't reimplement the
process_event
hook, I wasn't exactly sure when this would be needed and how it fit with psygnal/qt style events