Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix annotated in get_widget_class #525

Merged
merged 4 commits into from
Dec 11, 2022

Conversation

tlambert03
Copy link
Member

fixes #478, adding support for Annotated[...] types directly in get_widget_class

@tlambert03 tlambert03 changed the title fix: fix annotated in pick_widget_type fix: fix annotated in get_widget_class Dec 11, 2022
@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Base: 89.90% // Head: 89.90% // No change to project coverage 👍

Coverage data is based on head (08fb6cd) compared to base (52e0f26).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #525   +/-   ##
=======================================
  Coverage   89.90%   89.90%           
=======================================
  Files          38       38           
  Lines        4437     4437           
=======================================
  Hits         3989     3989           
  Misses        448      448           
Impacted Files Coverage Δ
src/magicgui/widgets/bases/_widget.py 87.87% <ø> (+0.44%) ⬆️
src/magicgui/signature.py 96.25% <100.00%> (-0.38%) ⬇️
src/magicgui/type_map/_type_map.py 96.69% <100.00%> (+0.16%) ⬆️
src/magicgui/widgets/bases/_create_widget.py 93.93% <0.00%> (-3.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tlambert03 tlambert03 merged commit 104b55d into pyapp-kit:main Dec 11, 2022
@tlambert03 tlambert03 deleted the fix-annotated branch December 11, 2022 19:16
@tlambert03 tlambert03 added the bug Something isn't working label Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Annotated types only work in function signatures
1 participant