feat: add KeyCombo.Ctrl and KeybindingRule.to_keybinding #230
+115
−56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #229
This PR adds two more KeyMods:
KeyMod.Ctrl
andKeyMod.Meta
most of the time, you will want to use
CtrlCmd
andWinCtrl
, since they do what is usually "expected" when the keycode is converted to a Keybinding object. But in cases where you just always want the control key, or meta key, regardless of platform, the new codes can be used. Note: it can be confusing if you combineCtrl
withCtrlCmd
... (it would be just ctrl on windows, but cmd+ctrl on macos) so it's definitely not recommended.It also adds some conveniences for debugging. It adds a public
KeyBindingRule.to_keybinding
method that takes in an optional os. so one can easily test how these things are resolved, on any platform