UPDATE: align EIC Guide tasks with GitHub labels #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on internal conversations, I updated the instance of `1-editor-checks` to ` 0/pre-review-checks `, and added `1/editor-assigned` to step four. I also added two missing octothorpes to references to Slack channels.
|
@kierisi this is the first i'm hearing of the term octothorpe 😆 i looked it up. wherever did that word come from!? it might me my new favorite word |
|
@all-contributors please add @kierisi for code, review |
|
I've put up a pull request to add @kierisi! 🎉 |
|
@lwasser Merriam-Webster says its origins are unknown! I came across a slide or blog post years ago that talked about how "octothorp" is the only globally-accepted term for "#" and so adopted the term from there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on internal conversations, I updated the instance of
1-editor-checksto0/pre-review-checks, and added1/editor-assignedto step four.I also added two missing octothorpes to references to Slack channels.