Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update editor steps to include reviewer info & update checklist #261

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Nov 9, 2023

This PR does a few things.

  1. it fixes a minor footer pydata sphinx theme deprecation
  2. it adds some language about the types of reviewers we ideally want for each package
  3. it updates the checklist at the end to include inviting folks to slack.

i'd love a review from 1-2 members our of @pyOpenSci/editorial-board if that is possible!! many thanks y'all!!

@lwasser
Copy link
Member Author

lwasser commented Nov 9, 2023

oops looks like a link is missing -
internally linking to #review-mentorshipreview-mentorship; the file exists, but the hash 'review-mentorshipreview-mentorship' does not

@lwasser
Copy link
Member Author

lwasser commented Nov 9, 2023

green light now on the pr. link is fixed

@lwasser
Copy link
Member Author

lwasser commented Nov 30, 2023

given there's been no feedback here i'm going to go ahead and merge this pr!!

@lwasser lwasser merged commit c983984 into pyOpenSci:main Nov 30, 2023
3 checks passed
@lwasser lwasser deleted the fix-editor branch November 30, 2023 22:58
@@ -188,7 +208,7 @@ Diversity is core to the pyOpenSci mission. As such it's important to have an
editorial team comprised of an editor + 2 reviewers from diverse backgrounds.

In your search for reviewers, please ensure ensure that there is diversity
in the team supporting package review. [Specifically both reviewers should have different backgrounds and different gender-identities whenever possible](reviewer-diversity). pyOpenSci [supports mentoring new reviewers if needed!](review-mentorshipreview-mentorship)
in the team supporting package review. Specifically both reviewers should have [different backgrounds and different gender-identities](reviewer-diversity) whenever possible. pyOpenSci [supports mentoring new reviewers if needed!](review-mentorship)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to this line, but the line above has please ensure ensure, it should probably be just please ensure.
maybe I should create an issue instead of adding this note here XD

Copy link
Contributor

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lwasser , it looks good to me. sorry for being late here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants