Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub icon link #218

Merged
merged 1 commit into from
May 26, 2023
Merged

Fix GitHub icon link #218

merged 1 commit into from
May 26, 2023

Conversation

dstansby
Copy link
Contributor

No description provided.

Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dstansby welcome to pyOpenSci!! 👋 Let me know if you have any questions etc about our guides, content etc as well!

Good catch here!! thank you for this PR. i'll merge it shortly and add you to our contributor list!!

@lwasser
Copy link
Member

lwasser commented May 26, 2023

ok the failure points here have nothing to do with this specific PR. there are some response codes of 0 and 301 that might be spurious and one other that might be a redirect (2i2c docs change) so i'll go ahead and merge this and will work on the other fixes separately

@lwasser lwasser merged commit 717e467 into pyOpenSci:main May 26, 2023
@lwasser
Copy link
Member

lwasser commented May 26, 2023

@all-contributors please add @dstansby for code, review

@allcontributors
Copy link
Contributor

@lwasser

I've put up a pull request to add @dstansby! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants