Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in package meta output - fork values appear twice! #50

Closed
lwasser opened this issue Jul 27, 2023 · 4 comments · Fixed by #63
Closed

bug in package meta output - fork values appear twice! #50

lwasser opened this issue Jul 27, 2023 · 4 comments · Fixed by #63
Labels
bug Something isn't working help wanted Extra attention is needed sprintable

Comments

@lwasser
Copy link
Member

lwasser commented Jul 27, 2023

@SultanOrazbayev noticed here that in our automated workflow - forks are listed twice .

 gh_meta:
      name: bibat
      description: A batteries-included template for Bayesian data analysis projects
      created_at: 03-04-2021
      stargazers_count: 10
      watchers_count: 10
      forks: 2
      open_issues_count: 8
      forks_count: 2
      documentation: https://bibat.readthedocs.io/
      contrib_count: 1
      last_commit: 07-14-2023

fix the metadata part of the workflow to remove that duplication! the metadata is captured in the parse_issues.py module.

@lwasser lwasser added the help wanted Extra attention is needed label Jul 27, 2023
@lwasser lwasser added sprintable bug Something isn't working labels Jul 27, 2023
@lwasser
Copy link
Member Author

lwasser commented Aug 20, 2023

this is still a bug - i missed fixing in the refactor but it should be pretty darn easy now to just update the GHmeta model attrs!!

@lwasser lwasser moved this to python programming in pyOpenSci Help Wanted Project Board Aug 20, 2023
SultanOrazbayev added a commit to SultanOrazbayev/update-web-metadata that referenced this issue Aug 21, 2023
@SultanOrazbayev
Copy link
Contributor

I gave it a shot, but not sure if that fixes it.

@lwasser
Copy link
Member Author

lwasser commented Aug 21, 2023

@all-contributors please add @SultanOrazbayev for code, review

oh thank you @SultanOrazbayev ?? many thanks! the fix in your fork should work. can you kindly submit it here to this repo as a pr and i can merge it. that looks perfect!! pydantic is amazing!

@allcontributors
Copy link
Contributor

@lwasser

I've put up a pull request to add @SultanOrazbayev! 🎉

lwasser pushed a commit that referenced this issue Aug 24, 2023
@github-project-automation github-project-automation bot moved this from python programming to Dev Ops / GitHub actions or GitHub related in pyOpenSci Help Wanted Project Board Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed sprintable
Projects
Development

Successfully merging a pull request may close this issue.

2 participants