Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A take on reordering pep-8 and code style section #31

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

sneakers-the-rat
Copy link
Contributor

Here's one take on #12

what ya think @willingc @lwasser

I also thought the admonitions were using sort of a goofy amount of vertical space so i tightened that down a bit

Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sneakers-the-rat thank you for this! i'm merging it now!! 🚀

@lwasser lwasser merged commit 3eb790c into pyOpenSci:main Oct 21, 2024
4 checks passed
@sneakers-the-rat
Copy link
Contributor Author

sneakers-the-rat commented Oct 21, 2024

ok! and of course if you or @willingc have additional edits please make them, i tried to keep your source text intact as much as possible, but i did edit a few headings just for the sake of document flow, but those can be changed back! I think the major thing i added was the discussion on linters/formatters, hopefully that wasn't too much detail (and hopefully it was correct).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants