Corrected PR: added the PR checklist #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pre-commit.ci autofix |
|
@lwasser this is ready for review, and should resolve the merge conflicts from #90, which I've closed with comment. I figured out what happened, and the fix was pretty straightforward. I had ended up committing the content from this PR on the wrong branch 🙃 I've checked this PR for the correct files, and the local build looks good on my end as it incorporates this new information, but doesn't make any changes to the canva pages. |
|
awesome. thanks @kierisi i'll give this a review today! |
lwasser
approved these changes
Sep 30, 2024
|
pre-commit.ci autofix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR corrects the merge conflicts in #90
the goal of this PR is to add a short checklist for users to follow when submitting a PR to pyOpenSci.